Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should output all assets #49

Closed
heygrady opened this issue Feb 16, 2019 · 3 comments
Closed

Should output all assets #49

heygrady opened this issue Feb 16, 2019 · 3 comments
Labels
fixed locally The issue has been resolved locally and will be merged soon

Comments

@heygrady
Copy link

heygrady commented Feb 16, 2019

Was trying to use this in an ejected create-react-app.

  1. create-react-app uses webpack-manifest-plugin, which is pretty useless (asset-manifest.json generated by CRA2 is not useful facebook/create-react-app#5513).
  2. The good thing about webpack-manifest-plugin is that it outputs every resource, including images and resources from copy-webpack-plugin
  3. The bad thing about webpack-manifest-plugin is that it has no support for entrypoints and integrity
  4. The bad thing about webpack-assets-manifest is that it's pretty useless to not include every resource when using SRI. For instance, how do I get the integrity of my various vendor chunks?

Why doesn't webpack-assets-manifest include every output resource?

@webdeveric
Copy link
Owner

Probably related to #25

@fsateler
Copy link

Looks like for some reason this plugin looks at stats.assetsByChunkName, but CopyWebpackPlugin does not add the files there (possibly because there is no chunk to attribute the files to?), instead it adds them to stats.assets

madflow added a commit to madflow/webpack-assets-manifest that referenced this issue Oct 19, 2020
madflow added a commit to madflow/webpack-assets-manifest that referenced this issue Oct 19, 2020
@webdeveric webdeveric added the fixed locally The issue has been resolved locally and will be merged soon label Oct 23, 2020
@guzart
Copy link

guzart commented Nov 22, 2020

@webdeveric anything I can help you with to release a fix for this issue? You mentioned there are other issues you need to close?

Edit: As a workaround I am using the sharing data functionality to manually add the files. Thank you for making the plugin so versatile.

webdeveric added a commit that referenced this issue Nov 24, 2020
- Minimum webpack version is now 4.40.0
- Updated dependencies - fixes #96
- Updated tests
- Added `enabled` option
- Added `entrypointsUseAssets` option - fixes #66
- Brought back the `contextRelativeKeys` option - fixes $44
- Use lock files when using `writeToDisk` - fixes #89
- Use lock files when emitting the manifest - fixes #64
- Get all compilation assets with `getAssets()` - fixes #56 #49 #25
- Swapped the key/value in `assetNames` - fixes #56
- Updated merge behavior for entrypoints - fixes #48
webdeveric added a commit that referenced this issue Nov 24, 2020
- Minimum webpack version is now 4.40.0
- Updated dependencies - fixes #96
- Updated tests
- Added `enabled` option
- Added `entrypointsUseAssets` option - fixes #66
- Brought back the `contextRelativeKeys` option - fixes #44
- Use lock files when using `writeToDisk` - fixes #89
- Use lock files when emitting the manifest - fixes #64
- Get all compilation assets with `getAssets()` - fixes #56 #49 #25
- Swapped the key/value in `assetNames` - fixes #56
- Updated merge behavior for entrypoints - fixes #48
webdeveric added a commit that referenced this issue Nov 25, 2020
- Minimum webpack version is now 4.40.0
- Updated dependencies - fixes #96
- Updated tests
- Added `enabled` option
- Added `entrypointsUseAssets` option - fixes #66
- Brought back the `contextRelativeKeys` option - fixes #44
- Use lock files when using `writeToDisk` - fixes #89
- Use lock files when emitting the manifest - fixes #64
- Get all compilation assets with `getAssets()` - fixes #56 #49 #25
- Swapped the key/value in `assetNames` - fixes #56
- Updated merge behavior for entrypoints - fixes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed locally The issue has been resolved locally and will be merged soon
Projects
None yet
Development

No branches or pull requests

4 participants