allow multiple assets to map to the same file on disk #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54. When using hashed filenames with
file-loader
, it's possible that two distinct resources in Webpack will map to the same file on disk (e.g. two copies of the same image). Currently, this plugin will only include one of them arbitrarily in the manifest.I've switched around
this.assetNames
to map from original filename to hashed filename to allow all of these assets to appear in the manifest.This change also resulted in some unexpected manifest entries, caused by the emitFile calls in
mini-css-extract-plugin
. It seems that the plugin always chose the first occurence of a file asset to intentionally skip over these (#39, #40), so I maintained this behavior by explicitly skipping all emitFile calls frommini-css-extract-plugin
. This is admittedly a little jank, but it seems to work.