This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Improved reporting of passing expectations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2019 07:35
…s changes to jasmine-core (being submitted separately as required) but does not break without those changes to jasmine-core.
BorisOsipov
reviewed
Jan 11, 2019
BorisOsipov
suggested changes
Jan 11, 2019
BorisOsipov
reviewed
Jan 11, 2019
|
Close\reopen to trigger travis |
|
@BorisOsipov I am not if the build works. It became broken when JWT support in Travis got discontinued. |
|
Ok disable Travis then for a while |
|
Is Travis disabled now? I tried closing/reopening just to check, but not a lot happened. Are we happy with this PR now? |
BorisOsipov
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s changes to jasmine-core (being submitted separately as required) but does not break without those changes to jasmine-core.
Proposed changes
As above, and in line with changes made to wdio-spec-reporter and wdio-jasmine-framework, I'm looking to improve the reporting from webdriverio
Types of changes
Checklist
Further comments
Reviewers: @christian-bromann