Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Electron Forge for example-cjs #243

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Use Electron Forge for example-cjs #243

merged 7 commits into from
Oct 29, 2023

Conversation

goosewobbler
Copy link
Member

  • Updated the CJS example app to use Electron Forge - ESM example can be done once this is merged
  • Updated ESM example to use Electron 28 alpha (instead of nightly)
  • Updated other deps

christian-bromann
christian-bromann approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We should keep one example using Electron builder just so we can e2e test the integration of it. Ideally apps build with both tools should be easily testable without any configuration.

@christian-bromann christian-bromann merged commit 107d4f1 into main Oct 29, 2023
4 checks passed
@christian-bromann christian-bromann deleted the update-examples branch October 29, 2023 15:35
@goosewobbler goosewobbler mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goosewobbler @christian-bromann