[fix] chromiumedge driver doesn't install on arm64 when user specifies "latest" for version #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of chromiumEdgeBundleAvailable
jdpolicano
force-pushed
the
chromiumedge-arm64-fix
branch
from
575c384 to
45f82de
Compare
jdpolicano
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small error when installing the chromium edge driver on the arm64 architecture. When the user selects "latest" for version, we were not passing the version info to the getChromiumEdgeDriverArchitectureOld function from chromiumEdgeBundleAvailable. This caused the function to fail silently, which would revert to the fallback version even if a later version was available.