a few conveniences #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few simplifications from the linter. Also, the changes to the processing instruction tests highlighted the fact the the struct fields are public. I added new function to prepare for making them private.
Make the fields of the PI struct private.
Being able to pretty-print an element with display can be useful, at least for debugging if nothing else.
There is a lot left to do, but this adds some preliminary datatypes for working with XML namespaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few conveniences that I wanted to have while using the library. Also makes the fields of
PIprivate, which is related to #9, which is already closed (must have forgotten processing instructions).