Skip to content

Commit

Permalink
fix(MeetingsAdapter): update Meeting definition to match ad-hoc meetings
Browse files Browse the repository at this point in the history
  • Loading branch information
lalli-flores authored and akoushke committed Dec 10, 2019
1 parent 29d59db commit 44b5bc0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
6 changes: 2 additions & 4 deletions src/MeetingsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ import WebexAdapter from './WebexAdapter';
* @typedef {Object} Meeting
* @property {string} ID The meeting identifier.
* @property {string} title The title of the meeting.
* @property {string} startTime The time and date of the start of the meeting. Must be a valid date-time string.
* @property {string} endTime The time and date of the end of the meeting. Must be a valid date-time string.
* @property {MediaStreamTrack} localVideo The local video stream track.
* @property {MediaStreamTrack} localAudio The local audio stream track.
* @property {MediaStream} localShare The local media share stream.
* @property {MediaStreamTrack} remoteVideo The remote video stream track.
* @property {MediaStreamTrack} remoteAudio The remote audio stream track.
* @property {MediaStream} remoteVideo The remote video stream.
* @property {MediaStream} remoteAudio The remote audio stream.
* @property {MediaStream} remoteShare The remote media share stream.
*/

Expand Down
26 changes: 14 additions & 12 deletions src/MeetingsAdapter.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,20 @@ describe('Meetings Adapter Interface', () => {
meetingsAdapter = null;
});

test('getMeeting() returns an observable', () => {
expect(isObservable(meetingsAdapter.getMeeting())).toBeTruthy();
});

test('getMeeting() errors because it needs to be defined', (done) => {
meetingsAdapter.getMeeting('meetingID').subscribe(
() => {},
(error) => {
expect(error.message).toBe('getMeeting(ID) must be defined in MeetingsAdapter');
done();
}
);
describe('getMeeting()', () => {
test('returns an observable', () => {
expect(isObservable(meetingsAdapter.getMeeting())).toBeTruthy();
});

test('errors because it needs to be defined', (done) => {
meetingsAdapter.getMeeting('meetingID').subscribe(
() => {},
(error) => {
expect(error.message).toBe('getMeeting(ID) must be defined in MeetingsAdapter');
done();
}
);
});
});

test('addLocalMedia() errors because it needs to be defined', () => {
Expand Down

0 comments on commit 44b5bc0

Please sign in to comment.