-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-meetings): Introduce SDK changes to call WCME and Locus APIs when current user steps away or returns #3942
Merged
antsukanova
merged 35 commits into
webex:brb-feature
from
antsukanova:antsukan/SPARK-559645
Nov 24, 2024
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
705a330
feat: introduce step away in sdk and test-app
07a6389
chore: rename functions, update wcme
d0882cf
chore: update brbChanged SelfUtils
315bab0
chore: update beRightBack, add todo
5cb3c55
chore: add todo
58e044e
fix(plugin-meetings): fix beRightBack sourceStateOverride
fnowakow 41b4452
fix(plugin-meetings): audio/video (un)mute fix
fnowakow 0f1af35
fix(plugin-meetings): added unit tests
fnowakow 15c48d5
fix(plugin-meetings): added NOT unit test
fnowakow 2e1080b
fix(plugin-meetings): updated tests
fnowakow 679ccf6
fix(plugin-meetings): added NOT unit test
fnowakow c155311
fix(plugin-meetings): updated tests
fnowakow 18521e7
fix(plugin-meetings): event name change to self
fnowakow 22e5a04
chore(plugin-meetings): add todo
fnowakow 4f1a9ee
chore(plugin-meetings): multistream support
fnowakow 5b5c132
chore(plugin-meetings): removed multistream
fnowakow d7549af
test(plugin-meetings): update brb tests
e12798e
chore: nit updates for logs
541dbe0
test(plugin-meetings): update brb test names
fa85fb5
chore: update beRightBack api logic
278e4e9
test(plugin-meetings): check brb for both multistream and transcoded
939509d
test(plugin-meetings): finalize brb tests
41cce5c
test(plugin-meetings): remove unnecessary stub
aa5c0df
test(plugin-meetings): re-arrange test and add afterEach
0417885
test(plugin-meetings): remove only
c74ef78
fix(plugin-meetings): log error
5941b61
fix(plugin-meetings): rever to return statement
ce7757f
fix(plugin-meetings): throw and log error
9a69c20
test(plugin-meetings): update brb tests
e87cd32
fix(plugin-meetings): log error
1a0b894
fix(plugin-meetings): throw and log error
fcc4f82
fix(plugin-meetings): adjust conditions for brb
52bddae
fix(plugin-meetings): update branch
3f11d6b
chore: update test and brb logic for transcoded meetings
91b1c15
chore: fix spacing
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be a button and not a checkbox, since it'll be a button in the web client. The button should reflect the brb status of the current user, and would be a good way for us to test whether we are able to accurately show our brb status in the UI, as well as handle any potential race condition that might occur because of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good comment, and I believe it's worth changing. We can improve this part in this task and not block the RP with this issue. https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-574653