Support Doctrine attributes alongside annotations in BaseTranslation
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relthyg
changed the title
relthyg
force-pushed
the
doctrine-attributes
branch
from
1c3ad56 to
adc22d4
Compare
relthyg
changed the title
mpdude
approved these changes
Apr 2, 2024
For the moment, we can't replace annotations by attributes in tests, as `webfactory/doctrine-orm-test-infrastructure` is strongly coupled to `Doctrine\ORM\Mapping\Driver\AnnotationDriver` and `Doctrine\Common\Annotations\AnnotationReader`.
mpdude
changed the title
BaseTranslation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Doctrine attributes to the MappedSuperclass
BaseTranslationwhile keeping the annotations in place. This allowsBaseTranslationto be used with either annotations or attribute-based Doctrine configurations.