Fill in dummy types to deal with DC2:... column comments #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janopae
reviewed
Jan 18, 2024
|
|
||
| public function convertToPHPValue($value, AbstractPlatform $platform) | ||
| { | ||
| throw new LogicException('this should not be called in the first place'); |
There was a problem hiding this comment.
Maybe we could have a better description in this file on why it exists. Maybe these error messages would be a good place for such a description.
It could be something like This Doctrine type assumes that the types won't be used to convert any data – it's just there to allow the rest of DBAL's functionality to work without throwing errors. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the
SchemaManagerto simplify listing tables, views and so on. But, the information provided by it also includes the DBAL types used for columns, and that information may be parsed from column comments in the database.The problem is that a table definition like so:
...
slimdumpfail fail with an exception because it does not know about thesome_type. This type may be available and defined in your application, but we cannot put it into theslimdumpcommand.Now, in fact, we don't care about the type and its conversion capabilities at all. So, this PR adds a runtime "just in type" registration of a
DummyTypethat serves as a placeholder to avoid issues when loading the schema.Fixes #96.