-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the docs about submodules and action ordering. #92
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan to document this
# This action has to precede ssh-agent, since it undoes its effects | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that is fixed in actions/checkout#833, unless submodules are used?
The `ssh-agent` step *cannot* precede the `checkout` step, though. The `checkout` action undoes the effects of `ssh-agent`. This will cause errors like: | ||
|
||
ssh: Could not resolve hostname key-<hex-key-id>.git.luolix.top: Name or service not known |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once actions/checkout#833 is merged, that should not happen unless submodules are turned on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is linked to #148 which is caused by the checkout action setting up a temp HOME directory which breaks the ssh configuration.
On linux, submodule support is OK with ssh-agent
preceding the checkout
action.
I prefer not to merge this unless I fully understand the problem and we have discussed possible alternative (?) solutions. I have opened actions/checkout#973 to co-ordinate with the |
Fixes #91