Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul of field demos #101

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Overhaul of field demos #101

merged 2 commits into from
Nov 18, 2024

Conversation

laurenic0l
Copy link
Contributor

Updating to reflect current best practices

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MatthewHawkins
MatthewHawkins approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@MatthewHawkins MatthewHawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may come back to these when we write the MaskedField demos, but for the meantime good deal

@MatthewHawkins MatthewHawkins merged commit 8e09e09 into main Nov 18, 2024
1 check passed
@MatthewHawkins MatthewHawkins deleted the fields-demos branch November 18, 2024 14:06
@hyyan hyyan mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewHawkins MatthewHawkins MatthewHawkins approved these changes

@hyyan hyyan Awaiting requested review from hyyan hyyan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurenic0l @MatthewHawkins