Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Expand all close all buttons are cut. #1985

Closed
sarvaje opened this issue Feb 27, 2019 · 9 comments · Fixed by #1989 or #3417
Closed

[Bug] Expand all close all buttons are cut. #1985

sarvaje opened this issue Feb 27, 2019 · 9 comments · Fixed by #1989 or #3417
Assignees
@sarvaje
Labels
area:formatter type:bug

Comments

@sarvaje
Copy link
Contributor

sarvaje commented Feb 27, 2019

Steps to reproduce:

  1. Go to https://webhint.io/scanner/
  2. Scan an url

Expected:
Expand/collapse all button should looks ok.

Actual:
image
image
@molant
Copy link
Member

molant commented Feb 27, 2019

Guess this is for @ststimac?

@sarvaje
Copy link
Contributor Author

sarvaje commented Feb 27, 2019

Yes, or for me if @ststimac doesn't have time.

@ststimac
Copy link
Member

I've got time. :)

@ststimac
Copy link
Member

This is one of the tasks under my "scan results clean up" already.

@sarvaje
Copy link
Contributor Author

sarvaje commented Feb 28, 2019

Ok!

ststimac added a commit to ststimac/hint that referenced this issue Feb 28, 2019
@ststimac
Fix: Button cut off and misc a11y fix
05b681c 
Adjusted code to fix the expand all, close all button being cut off.
Removed unnecessary role=main on the Hints container.

Fix webhintio#1985
@ststimac ststimac mentioned this issue Feb 28, 2019
Merged
4 tasks
molant pushed a commit that referenced this issue Mar 1, 2019
@ststimac @molant
Fix: Button cutoff and misc a11y issues
a606ada 
* Adjusted code to fix the expand all, close all button being cut off.
* Removed unnecessary role=main on the Hints container.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1985
Close #1989
@ststimac
Copy link
Member

Hmmm, so this is still showing up in the formatter as cut off.

@ststimac ststimac reopened this Mar 15, 2019
@molant
Copy link
Member

molant commented Mar 15, 2019

In the website or using the CLI? We haven't released a new version of the site in a few days because of an issue with SRI and I'm not sure if the change got in the latest published version if you are using the CLI.

@ststimac
Copy link
Member

I've cleared my cache just to make sure, but the old code and style is still coming through. Need to look into this.

@ststimac
Copy link
Member

Still an issue, but only in one state:

Screen Shot 2019-03-15 at 9 20 42 AM

Background position is only being applied to the closed class.

@sarvaje sarvaje assigned sarvaje and unassigned ststimac Dec 2, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Dec 4, 2019
@sarvaje
Fix: Close/Expand all button
8d810fb 
Fix webhintio#1985
@sarvaje sarvaje mentioned this issue Dec 4, 2019
Merged
4 tasks
molant pushed a commit that referenced this issue Dec 4, 2019
@sarvaje @molant
Fix: Close/Expand "All" button
2473518 
Fix #1985
Close #3417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarvaje sarvaje

Labels
area:formatter type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix button cutoff and misc a11y issue ststimac/hint
Fix: Close/Expand all button sarvaje/hint
3 participants
@molant @sarvaje @ststimac