Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: PHP\DisallowFqn when namespace is already in use #93

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Hotfix: PHP\DisallowFqn when namespace is already in use #93

merged 1 commit into from
Apr 6, 2020

Conversation

michalbundyra
Copy link
Member

Failing case:

namespace A;

use B;

new B();
new \B\C();

Expected result:

namespace A;

use B;

new B();
new B\C();

Actual result:

namespace A;

use B;

new B();
new B();

@michalbundyra michalbundyra added the bug Something isn't working label Apr 4, 2020
@michalbundyra michalbundyra added this to the 1.1.5 milestone Apr 4, 2020
michalbundyra added a commit that referenced this pull request Apr 6, 2020
@michalbundyra
Adds CHANGELOG entry for #93
dd1f8c7
michalbundyra added a commit that referenced this pull request Apr 6, 2020
@michalbundyra
Merge branch 'hotfix/93' into develop
7280be1 
Forward port #93
@michalbundyra michalbundyra merged commit 7193b51 into webimpress:master Apr 6, 2020
@michalbundyra michalbundyra deleted the hotfix/disallow-fqn-import branch April 6, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.5
Development

Successfully merging this pull request may close these issues.
1 participant
@michalbundyra