Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out shareable parts of the summarizer spec #40

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Feb 7, 2025

These can all power other AI specs.

Notable changes that aren't just moving stuff around:

  • The creation of the AIDestroyable mixin to help centralize destruction logic.
  • The use of dependent abort signals to make it easier to handle both destroying a model object and aborting an operation.
  • We now acknowledge that starting a download might fail, and handle that.
  • Added missing awaits to the availability language example.
  • Added missing task queuing to availability(). Fixes Missing tasks in parallel steps in Writing Assistance APIs #39.
  • Fixed a bad link to summarizeStreaming() in the errors section.

Preview | Diff

These can all power other AI specs.

Notable changes that aren't just moving stuff around:

* The creation of the AIDestroyable mixin to help centralize destruction logic.
* The use of dependent abort signals to make it easier to handle both destroying a model object and aborting an operation.
* We now acknowledge that starting a download might fail, and handle that.
* Added missing awaits to the availability language example.
* Added missing task queuing to availability(). Fixes #39.
* Fixed a bad link to summarizeStreaming() in the errors section.
@domenic domenic merged commit 598f16d into main Feb 10, 2025
2 checks passed
@domenic domenic deleted the abstraction-only branch February 10, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tasks in parallel steps in Writing Assistance APIs
1 participant