Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.3 compatibility issues - "Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value." #32

Open
praveenkaransingh opened this issue Sep 15, 2020 · 1 comment

Comments

@praveenkaransingh
Copy link

praveenkaransingh commented Sep 15, 2020

Steps to reproduce
phpcs -p -s -v --standard=PHPCompatibility vendor/webmozart/ --runtime-set testVersion 7.3 --report-full=PHP_7_3_Compatibility_vendor_webmozart.log --extensions=php,module,inc -d memory_limit=512M

Generated report from phpcs & found one warning below -

FILE: /vendor/webmozart/path-util/src/Path.php

 852 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$paths" was used, and possibly
     |         | changed (by reference), on line 851. (PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection)
@praveenkaransingh
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant