add fallback if document.currentScript is not available (e.g. with Webkitties) #694
Conversation
|
Build succeeded. |
| a, pathname, pos; | ||
|
|
||
| if (document.currentScript && document.currentScript.src) { | ||
| scriptElement = document.currentScript.src; | ||
| } else { | ||
| scriptElement = (function() { |
There was a problem hiding this comment.
Please make this one or more separate documented functions.
|
Build succeeded. |
| pathname = a.pathname; | ||
|
|
||
| pos = pathname.lastIndexOf("/"); | ||
| if (pos !== -1) { | ||
| path = pathname.substr(0, pos); | ||
| } | ||
| } else { | ||
| throw "Could not estimate installationPath of the Wodo.TextEditor."; |
There was a problem hiding this comment.
Throwing is nice, but who catches this?
This script is run globally, so throwing here means wodo namespace is undefined.
Since that's exceptional i.e. an unexpected runtime environment or bad setup, showing an alert is permissible in my opinion. At any rate, documenting the expected global outcome here makes sense.
There was a problem hiding this comment.
Throwing is nice, but who catches this?
Hm, right. If that is included by a <script> element in the header, I have no idea who could catch that. Written without thinking more it seems (perhaps not wanting to spent time on the unexpected, meh).
So an alert is the usual pattern on an error during code run on inclusion of a JS file? Okay, changed.
Not clear to me: where would you expect the documentation to be done, and what exactly do you mean with "expected global outcome"?
|
Build succeeded. |
|
Works in chromium and firefox. Tried in KHTML 4.12.4 but that does not work, I'm not sure if this patch is supposed to fix that. |
add fallback if document.currentScript is not available (e.g. with Webkitties)
|
Thanks, WebODF is now working in Safari 👍 |
Fixes #693