Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in FF for double line-through #758

Merged
merged 1 commit into from
Aug 8, 2014

Conversation

peitschie
Copy link
Contributor

Follows CSS3 standards. Unfortunately, only FF implements this so far.

Unfortunately, no layout tests are possible as getComputedStyle only returns style information it understands, which differs from browser to browser. It is possible to write a layouttest that passes in FF, or one that passes in Chrome (not that I can check anything in Chrome), but not one that passes in both.

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2054/

@adityab
Copy link
Member

adityab commented Aug 8, 2014

Ship this please!

@adityab
Copy link
Member

adityab commented Aug 8, 2014

Oh, please add a changelog entry as well.

@peitschie
Copy link
Contributor Author

It already has one :-)

@kossebau
Copy link
Contributor

kossebau commented Aug 8, 2014

So much for 😎 inside buildings ;)

Follows CSS3 standards. Unfortunately, only FF implements this so far.
@adityab
Copy link
Member

adityab commented Aug 8, 2014

Meh. Stupid me. 🚢

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2078/

peitschie added a commit that referenced this pull request Aug 8, 2014
Add support in FF for double line-through
@peitschie peitschie merged commit f684097 into webodf:master Aug 8, 2014
@peitschie peitschie deleted the style-double-strike branch August 8, 2014 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants