Only process signals created by an operation after execution is complete #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peitschie
force-pushed
the
delay-emit
branch
from
14d4db2
to
7f28bd8
Compare
|
Build succeeded. |
|
The new pattern is simple and upon testing in a collaborative environment did not give any problems. Please ship it! |
These events feed straight into the steps cache, and must be processed by the cache before any external consumers receive the event.
This ensures the operation cannot be accidentally interrupted by an external consumer of an event.
peitschie
force-pushed
the
delay-emit
branch
from
7f28bd8
to
662c2c8
Compare
|
Build succeeded. |
|
Thanks for taking the time to review :-) |
peitschie
added a commit
that referenced
this pull request
Sep 18, 2014
Only process signals created by an operation after execution is complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the operation cannot be accidentally interrupted by an external consumer of an event.