Fix position instability around highlighted annotation #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peitschie
force-pushed
the
position-stability
branch
from
006fbc6
to
40b5097
Compare
|
Build succeeded. |
|
This patch has survived a weekend of fuzzing with a definite reduction in crashes (4.4% failure rate in the first 2000 actions vs. > 20%). |
peitschie
force-pushed
the
position-stability
branch
from
40b5097
to
26b1d39
Compare
|
Build succeeded. |
peitschie
force-pushed
the
position-stability
branch
2 times, most recently
from
c26f35b
to
2092031
Compare
|
Build succeeded. |
|
Build succeeded. |
|
Looks fine, please rebase and 🚢 |
By checking only nodes that pass the supplied node filter, the position logic can safely ignore out-of-place cursors near highlighted annotations. Note, this can't re-use PositionIterator.previousNode, because the logic requires the previous sibling of the current container's previous sibling.
peitschie
force-pushed
the
position-stability
branch
from
2092031
to
9fba50a
Compare
|
Build succeeded. |
|
Thanks for reviewing @adityab 😃 |
peitschie
added a commit
that referenced
this pull request
Sep 30, 2014
Fix position instability around highlighted annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #783
By checking only nodes that pass the supplied node filter, the position logic can safely ignore out-of-place cursors near highlighted annotations.