Fix/upgrade to wgpu 0.13.1 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, attribute syntax has changed (e.g. [[stage(compute)]] becomes @compute, Scalar(x) construction is not supported anymore, matrixes of integers are not supported anymore, and some more specific changes)
Merged
|
And with the last few commits, WASM works again (at least on Chrome - for some reason Firefox says it cannot find a GPU given preferences on my machine, YMMV) |
|
On Firefox (Nightly Passing |
haixuanTao
reviewed
Jul 4, 2022
haixuanTao
reviewed
Jul 4, 2022
Co-authored-by: Xavier Tao <tao.xavier@outlook.com>
haixuanTao
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades wgsl from v0.12.0 to v.0.13.1. This is a long awaited update that (among other things) updates the WGSL syntax to follow the latest standard (which e.g. Google Chrome (Tint) currently uses as well).
Tests pass on my machine and all examples work. Will do some more testing, there may be some edge cases here and there (in particular for ops where scalar_type is an integer - we can't use matrixes anymore for these because WGSL now only supports float-based matrixes).