Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 Drop @throws Error from protected method ReferenceExecutor::executeOperation #1660

Merged
merged 1 commit into from
Dec 2, 2024
Merged

📦 Drop @throws Error from protected method ReferenceExecutor::executeOperation #1660

merged 1 commit into from
Dec 2, 2024

Conversation

andrew-demb
Copy link
Contributor

This method catches Error and converts them to the return null and adds error to the context (

graphql-php/src/Executor/ReferenceExecutor.php

Lines 328 to 332 in f7b2ee0

} catch (Error $error) {
$this->exeContext->addError($error);
return null;
}
)

@andrew-demb
📦 Drop @throws Error from protected method
47f52df 
This method catches `Error` and converts them to the `return null` and added error to the context
@andrew-demb andrew-demb changed the title 📦 Drop @throws Error from protected method 📦 Drop @throws Error from protected method ReferenceExecutor::executeOperation Dec 2, 2024
@spawnia spawnia merged commit b7b5bfc into webonyx:master Dec 2, 2024
16 checks passed
@spawnia
Copy link
Collaborator

spawnia commented Dec 2, 2024

Thank you @andrew-demb

@andrew-demb andrew-demb deleted the patch-1 branch December 2, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-demb @spawnia