Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fast fixes #234

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Some fast fixes #234

merged 1 commit into from
Feb 8, 2018

Conversation

mcg-web
Copy link
Collaborator

@mcg-web mcg-web commented Feb 1, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 92.84% when pulling 944cceb on mcg-web:some-fixes into ccecc3c on webonyx:master.

@vladar
Copy link
Member

vladar commented Feb 2, 2018

What is the point of silencing trigger_error?

The whole idea behind it is to actually trigger an error. PHP has quite good error_reporting settings + ability to define custom error handler if required to intercept those.

We also have a GraphQL\Error\Warning to set up warnings which can be suppressed on demand. If you need suppressing those errors then it is better to convert trigger_error calls to corresponding GraphQL\Error\Warning::warnOnce or GraphQL\Error\Warning::warn and use GraphQL\Error\Warning::suppress with error ids.

@mcg-web
Copy link
Collaborator Author

mcg-web commented Feb 2, 2018

ok didn't know about those tools, i will remove this commit 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants