fix setting compression level for brotliCompress #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What fixes would you like to see in the code? It comes to my mind that different default parameters may be passed depending on the algorithm. Do you see any other changes needed? |
|
I mean this https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/src/index.js#L70, we should always set to maximum, for brotly too |
180254
changed the title
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
===========================================
- Coverage 98.77% 86.66% -12.11%
===========================================
Files 8 4 -4
Lines 326 165 -161
Branches 92 48 -44
===========================================
- Hits 322 143 -179
- Misses 2 20 +18
Partials 2 2
Continue to review full report at Codecov.
|
…ib#154) Signed-off-by: Adrian Pedziwiatr <180254@users.noreply.github.com>
…k-contrib#154) Signed-off-by: Adrian Pedziwiatr <180254@users.noreply.github.com>
180254
changed the title
180254
changed the title
180254
changed the title
180254
changed the title
|
I think it's done now. Please check this PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #154.
Breaking Changes
No
Additional Info
No