Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle errors #544

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

handle more errors

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #544 into master will decrease coverage by 4.05%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   95.71%   91.66%   -4.06%     
==========================================
  Files           3        3              
  Lines         257      276      +19     
  Branches       86       88       +2     
==========================================
+ Hits          246      253       +7     
- Misses         11       23      +12     
Impacted Files Coverage Δ
src/index.js 91.60% <61.29%> (-4.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b971374...beecf39. Read the comment docs.

@alexander-akait
Copy link
Member Author

Need improve tests, will do it in future

@alexander-akait alexander-akait merged commit f98be10 into master Oct 22, 2020
@alexander-akait alexander-akait deleted the refactor-code-more-try-catch branch October 22, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant