-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 breaks css-module-loader #1134
Comments
I don't understand the problem, please clarify
It is breaking change, you can disable this behavior |
At the moment there is no way to have a loader above css-loader process css-modules, in v3 there was a hacky way to do it. |
@jquense Maybe you need |
I think that would work, let me get a PR together if that sounds reasonable |
@jquense Go ahead, it is allow fix hacky setup for |
Fixed, now you can add |
Realized that the |
hm, interesting use case |
Not sure what the best approach would be for options here that doesn't break the new behavior? Maybe making |
I think ideally we should have:
default is Unfortunately, we cannot remove this option now, but I propose to do deprecation until many people have used it. Also you can use other options like |
yeah that makes sense, should have thought through this a bit more first sorry. I'll send a follow up. We can likely just remove |
Yes, let's do it |
WIP, other developers have problems with it too |
Hey @evilebottnawi the change that only adds the ICSS plugins breaks the strategy used by https://github.com/jquense/css-module-loader to convert modules into
:import
and:export
rules which depended on the (admittedly weird) behavior of css-loader always including the icss plugin.It's not enough to turn on
modules
tho b/c css-loader will then rehash everything. For this sort of thing to work we need an api to handle downstream import/exports without css-loader trying to process css-modules. This is also true for the newauto
default. it's not safe to assume any.module.css
file should be processed by css-loader when there are loaders ahead of it.Would love if we could come up with a first class API for this!
The text was updated successfully, but these errors were encountered: