Remove webpack from peerDependencies

[feedm3]

Modification Proposal

We are using css-loader with rsbuild. This means, we don't use webpack directly anymore / don't have it installed. css-loader still works fine with the setup, but when doing a yarn install, yarn complains about not having webpack listed in our dependencies.

➤ YN0002: │ my-awesome-rsbuild-webapp doesn't provide webpack (p1ea2d), requested by css-loader.

As css-loader doesn't use webpack directly, I think it's ok to just remove it from the peerDependencies array.

Expected Behavior / Situation

The loader will behave the same, but in the context of rsbuild won't add a warning in the install logs.

Actual Behavior / Situation

A warning in the install logs:

➤ YN0002: │ my-awesome-rsbuild-webapp doesn't provide webpack (p1ea2d), requested by css-loader.

[alexander-akait]

We can't remove webpack, we can do this https://github.com/jantimon/html-webpack-plugin/blob/main/package.json#L58 and this https://github.com/jantimon/html-webpack-plugin/blob/main/package.json#L62

[snitin315]

Does rspack support all loaders & plugins? We'll need to update it in them too.

[feedm3]

We can't remove webpack, we can do this jantimon/html-webpack-plugin@main/package.json#L58 and this jantimon/html-webpack-plugin@main/package.json#L62

Hm, I guess that doesn't really help. Now not only Webpack but also Rspack is required, so all Webpack users will also get this installation warning. AFAIK there is no way to have conditional peerDependencies. :/

Does rspack support all loaders & plugins? We'll need to update it in them too.

Not sure which ones are compatible, but "Rspack loader is designed to reuse the webpack loader, it is compatible with most of the webpack loader API, the rest of the API is still being implemented, so most of the webpack loader can already run in Rspack."

• https://www.rspack.dev/api/loader-api.html#loader-api
• https://github.com/orgs/web-infra-dev/projects/10

[alexander-akait]

@feedm3 Please read how peerDependenciesMeta works, it was designed specifically for this and we use this for other loaders/plugins/tools which have compatibility with rspack

[feedm3]

@feedm3 Please read how peerDependenciesMeta works, it was designed specifically for this and we use this for other loaders/plugins/tools which have compatibility with rspack

Oh sorry, I totally overlooked that one! You are right, this looks like a solution :)

[alexander-akait]

@feedm3 Feel free to send a PR

[feedm3]

@alexander-akait: There is now a PR for css-loader and postcss-loader:

• feat: add @rspack/core as an optional peer dependency #1568
• feat: add @rspack/core as an optional peer dependency postcss-loader#679