Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webpack from peerDependencies #678

Closed
feedm3 opened this issue Jan 25, 2024 · 1 comment · Fixed by #679
Closed

Remove webpack from peerDependencies #678

feedm3 opened this issue Jan 25, 2024 · 1 comment · Fixed by #679

Comments

@feedm3
Copy link

feedm3 commented Jan 25, 2024

Modification Proposal

We are using postcss-loader with rsbuild. This means, we don't use webpack directly anymore / don't have it installed. postcss-loader still works fine with the setup, but when doing a yarn install, yarn complains about not having webpack listed in our dependencies.

➤ YN0002: │ my-awesome-rsbuild-webapp doesn't provide webpack (p1ea2d), requested by postcss-loader.

As postcss-loader doesn't use webpack directly, I think it's ok to just remove it from the peerDependencies array.

Expected Behavior / Situation

The loader will behave the same, but in the context of rsbuild won't add a warning in the install logs.

Actual Behavior / Situation

A warning in the install logs:

➤ YN0002: │ my-awesome-rsbuild-webapp doesn't provide webpack (p1ea2d), requested by postcss-loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants