-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incomplete-sanitization in getUrl.js #1621
Comments
ruchira-net
added a commit
to ruchira-net/css-loader
that referenced
this issue
Nov 22, 2024
4 tasks
ruchira-net
added a commit
to ruchira-net/css-loader
that referenced
this issue
Nov 26, 2024
ruchira-net
added a commit
to ruchira-net/css-loader
that referenced
this issue
Nov 26, 2024
ruchira-net
added a commit
to ruchira-net/css-loader
that referenced
this issue
Dec 2, 2024
#1622 (comment), It looks like the utility has false positive result here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
When scanned with CodeQL scanner, it finds a incomplete sanitization issue in the getUrl.js file.
Actual Behavior
Below method doesn't escape backslash characters in the input.
Expected Behavior
Method should sanitize untrusted input for preventing injection attacks such as SQL injection or cross-site scripting (Even if the escaped string is not used in a security-critical context, incomplete escaping may still have undesirable effects, such as badly rendered or confusing output).
How Do We Reproduce?
Please paste the results of
npx webpack-cli info
here, and mention other relevant informationSystem:
OS: Windows 11 10.0.26100
CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1255U
Memory: 13.15 GB / 31.69 GB
Binaries:
Node: 21.6.2 - C:\Program Files\nodejs\node.EXE
npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Chromium (130.0.2849.46)
Internet Explorer: 11.0.26100.1882
The text was updated successfully, but these errors were encountered: