Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #826

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Refactor code #826

merged 3 commits into from
Nov 30, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Avoid unnecessary complex some function

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #826 into master will decrease coverage by <.01%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.01%     
==========================================
  Files          10       10              
  Lines         395      393       -2     
  Branches       95       90       -5     
==========================================
- Hits          389      387       -2     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️
lib/utils.js 90.32% <88.88%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee409c5...59e469a. Read the comment docs.

@alexander-akait alexander-akait merged commit 255c0f0 into master Nov 30, 2018
@alexander-akait alexander-akait deleted the refactor-code branch November 30, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant