Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Fixed: ignore cache when eslint rules have changed #151

Merged
merged 2 commits into from
Feb 22, 2017

Conversation

peternewnham
Copy link
Contributor

I appear to have borked my previous branch after rebasing and it was easier to create a new one from master than figure out what I did wrong :)

This is a fix for #124 and the approach is as follows:

  • Get a lint rules object for each CLIEngine instance (using CLIEngine.getConfigForFile)
    • This is taken from the rules of the first file to be processed for each engine (I assume every file processed by the same engine will share the same lint rules)
  • Hash the rules object
  • Include the hashed rule in the cache against each file so it can also be compared when deciding whether to use the cache

@viankakrisna
Copy link
Contributor

any update on this? need this to make facebook/create-react-app#1578 possible :)

@MoOx
Copy link
Contributor

MoOx commented Feb 22, 2017

We should adjust the PR with the new test runner used. @wrakky Can you take care of this?

@peternewnham
Copy link
Contributor Author

Oops I thought I did that already. Should be sorted now :)

@MoOx MoOx merged commit c667541 into webpack-contrib:master Feb 22, 2017
@MoOx
Copy link
Contributor

MoOx commented Feb 22, 2017

Released as 1.6.3

@xtroncode
Copy link

xtroncode commented Nov 6, 2019

I am facing this issue in ^3.0.2 for eslint-loader, looking at the latest code, it does not seem to consider the rules hash @MoOx @wrakky
sorry there is already an open issue #214

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants