Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

fix module build failed error at Linter.parseResults #294

Merged
merged 4 commits into from
Sep 24, 2019
Merged

fix module build failed error at Linter.parseResults #294

merged 4 commits into from
Sep 24, 2019

Conversation

buihdk
Copy link
Contributor

@buihdk buihdk commented Sep 22, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

I am using the latest eslint-loader v3.0.0 on my rejected create-react-app and encountered this issue when I tried to start the app: TypeError: Cannot read property 'forEach' of undefined. This is the fix for this error.

Screen Shot 2019-09-23 at 3 11 47 AM

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Khoa Bui Hoang Dang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #294   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         133    134    +1     
  Branches       27     28    +1     
=====================================
+ Hits          133    134    +1
Impacted Files Coverage Δ
src/Linter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4895987...6211567. Read the comment docs.

src/Linter.js Outdated Show resolved Hide resolved
@ricardogobbosouza
Copy link
Collaborator

@buihdk fix messages of commits, CI is not passing.

type(subject?): message

try:

fix: module build failed error at Linter.parseResults

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

@buihdk
Copy link
Contributor Author

buihdk commented Sep 23, 2019

Can we add tests?

Do you want end-to-end tests or just unit tests i.e. I'll add a Linter.test.js file to cover specific cases for above issue.

@alexander-akait
Copy link
Member

alexander-akait commented Sep 23, 2019

@buihdk unit tests enough

test/Linter.test.js Outdated Show resolved Hide resolved
test/Linter.test.js Outdated Show resolved Hide resolved
@ricardogobbosouza
Copy link
Collaborator

@evilebottnawi I don't have permission to merge 😞

@alexander-akait
Copy link
Member

@ricardogobbosouza strange, you have write, what is github writes to you?

@ricardogobbosouza
Copy link
Collaborator

@evilebottnawi You’re not authorized to merge this pull request.

@alexander-akait
Copy link
Member

alexander-akait commented Sep 24, 2019

@ricardogobbosouza let's investigate this situation, i want to add permissions on merge and release

@alexander-akait
Copy link
Member

@ricardogobbosouza Can you check again?

@ricardogobbosouza ricardogobbosouza merged commit 360e69c into webpack-contrib:master Sep 24, 2019
@alexander-akait
Copy link
Member

/cc @ricardogobbosouza can you give npm username?

@ricardogobbosouza
Copy link
Collaborator

@evilebottnawi sure, its same ricardogobbosouza

@alexander-akait
Copy link
Member

@ricardogobbosouza please enable 2FA

@ricardogobbosouza
Copy link
Collaborator

@evilebottnawi enabled

@alexander-akait
Copy link
Member

@ricardogobbosouza now you can do release:

  1. npm run release
  2. check CHANGELOG.md is good and you have new tag (npm run release do this automatically, just manual checking)
  3. push release commit to master and push new tag
  4. fill release (https://github.com/webpack-contrib/eslint-loader/releases), just copy/paste from CHANGELOG.md
  5. run npm publish

@ricardogobbosouza
Copy link
Collaborator

@evilebottnawi thanks

@buihdk buihdk deleted the fix/load-with-rejected-react-app branch September 25, 2019 07:36
@misha-panyushkin
Copy link

@evilebottnawi @ricardogobbosouza hey man! how is it going with releasing bugfix?

P.S. I will appreciate your new release with this fix. 🙏 Actually need your attention at the moment
thanks a lot

@alexander-akait
Copy link
Member

@misha-panyushkin near future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants