Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add ignoreOrder check #520

Conversation

keepitreal
Copy link

This PR adds the ignoreOrder checks added by #166 in the master branch. I realize the optimum solution for this issue is to migrate to Webpack 2 but since I'd consider this issue fairly debilitating, I think a fix should be present for those who need something in their production environments right away and can't go through the steps to migrate.

@jsf-clabot
Copy link

jsf-clabot commented May 30, 2017

CLA assistant check
All committers have signed the CLA.

@keepitreal keepitreal mentioned this pull request May 30, 2017
@codecov
Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #520 into webpack-1 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           webpack-1     #520   +/-   ##
==========================================
  Coverage      80.76%   80.76%           
==========================================
  Files              4        4           
  Lines            338      338           
  Branches          71       71           
==========================================
  Hits             273      273           
  Misses            65       65
Impacted Files Coverage Δ
index.js 80.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db50ee...6d36ef0. Read the comment docs.

@alexander-akait
Copy link
Member

@keepitreal Support legacy code (options, functions, checks, and etc) is a bad practice (we use semver to avoid accumulation this legacy stuff). I would advise you to find the time and go to webpack v2 or do fork and use this fork for own packages, where your use webpack v1. Not here. Thanks!

@michael-ciniawsky
Copy link
Member

@bebraw @d3viant0ne We can still cut a release for v1.x? The question is if we want to take the eventual risk that this might break something in general, if not then better close the PR :)

@joshwiens
Copy link
Member

imo, given that we are about to release 3.x the time for adding features for Webpack 1.x has come and gone.

@TheLarkInn
Copy link

Agreed.

@joshwiens
Copy link
Member

And for reference, 1.x is already not supported in the current release version.

screen shot 2017-06-07 at 9 38 53 pm

@joshwiens
Copy link
Member

@keepitreal - If you need a hand getting that upgraded shoot us an @ and we'll get you squared away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants