This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix: allow to override publicPath with an empty string #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
suggested changes
Apr 15, 2017
index.js
Outdated
| @@ -61,7 +61,7 @@ module.exports = function(content) { | |||
| } | |||
|
|
|||
| var publicPath = "__webpack_public_path__ + " + JSON.stringify(url); | |||
| if (config.publicPath) { | |||
| if (config.publicPath || config.publicPath === "") { | |||
michael-ciniawsky
changed the title
|
Made the change. My pleasure! :) |
bebraw
approved these changes
Apr 15, 2017
|
The webpack config validator does not allow |
|
@rtsao Can you open an issue so we don't lose the info and get it fixed? Thanks. |
This was referenced May 1, 2017
This was referenced Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix.
Did you add tests for your changes?
Yes.
Summary
When checking if the publicPath option was set, it would only do a falsy check which would return false with an empty string. Modified it to also set the public path if an empty string is given.
Does this PR introduce a breaking change?
No.
Other information