Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply webpack-defaults #134

Merged
merged 3 commits into from
Dec 5, 2017
Merged

refactor: apply webpack-defaults #134

merged 3 commits into from
Dec 5, 2017

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Jul 17, 2017

Type

  • Refactor

Features

component.js

import template from 'template.html'

const html = template({ ...locals })

Breaking Changes

  • Yes

The loader exports an ES2015 Module be default => export default ${html}
Options to configure the exporting behaviour are removed

  • Impact: low
  • Migration: not required

TODO

Closes #121

@codecov
Copy link

codecov bot commented Jul 17, 2017

Codecov Report

Merging #134 into next will decrease coverage by 63.18%.
The diff coverage is 33.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##             next     #134       +/-   ##
===========================================
- Coverage   96.96%   33.78%   -63.19%     
===========================================
  Files           2        3        +1     
  Lines          99       74       -25     
  Branches       20       13        -7     
===========================================
- Hits           96       25       -71     
- Misses          3       41       +38     
- Partials        0        8        +8
Impacted Files Coverage Δ
src/cjs.js 0% <0%> (ø)
src/index.js 29.68% <29.68%> (ø)
src/lib/attrs.js 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b13d4c...b2e5aab. Read the comment docs.

@hemanth
Copy link
Contributor

hemanth commented Dec 5, 2017

This needs a rebase, let us get this in!

@joshwiens joshwiens changed the base branch from master to next December 5, 2017 04:42
@joshwiens joshwiens merged commit 345eb3c into next Dec 5, 2017
@joshwiens joshwiens deleted the develop branch December 5, 2017 04:49
michael-ciniawsky added a commit that referenced this pull request Jan 8, 2018
* refactor: apply `webpack-defaults`

* squash: add LoaderError && init test refactor

* squash: more tests, small refactor
michael-ciniawsky added a commit that referenced this pull request Feb 6, 2018
BREAKING CHANGE: requires `node >= v6.0.0`
BREAKING CHANGE: requires `webpack >= v3.0.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants