docs: update splitChunks info (#637)

webpack-contrib · Oct 23, 2020 · bd7e0ba · bd7e0ba
1 parent a89c0f9
commit bd7e0ba
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -767,12 +767,15 @@ This also prevents the CSS duplication issue one had with the ExtractTextPlugin.
 const path = require('path');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
 
-function recursiveIssuer(m) {
-  if (m.issuer) {
-    return recursiveIssuer(m.issuer);
+function recursiveIssuer(m, c) {
+  const issuer = c.moduleGraph.getIssuer(m);
+  // For webpack@4 chunks = m.issuer
+
+  if (issuer) {
+    return recursiveIssuer(issuer, c);
   }
 
-  const chunks = m.getChunks();
+  const chunks = c.chunkGraph.getModuleChunks(m);
   // For webpack@4 chunks = m._chunks
 
   for (const chunk of chunks) {
@@ -793,14 +796,16 @@ module.exports = {
         fooStyles: {
           name: 'styles_foo',
           test: (m, c, entry = 'foo') =>
-            m.constructor.name === 'CssModule' && recursiveIssuer(m) === entry,
+            m.constructor.name === 'CssModule' &&
+            recursiveIssuer(m, c) === entry,
           chunks: 'all',
           enforce: true,
         },
         barStyles: {
           name: 'styles_bar',
           test: (m, c, entry = 'bar') =>
-            m.constructor.name === 'CssModule' && recursiveIssuer(m) === entry,
+            m.constructor.name === 'CssModule' &&
+            recursiveIssuer(m, c) === entry,
           chunks: 'all',
           enforce: true,
         },

diff --git a/test/cases/split-chunks-recursiveIssuer/webpack.config.js b/test/cases/split-chunks-recursiveIssuer/webpack.config.js
@@ -2,13 +2,17 @@ import { version as webpackVersion } from 'webpack';
 
 import Self from '../../../src';
 
-function recursiveIssuer(m) {
-  if (m.issuer) {
-    return recursiveIssuer(m.issuer);
+function recursiveIssuer(m, c) {
+  const issuer =
+    webpackVersion[0] === '4' ? m.issuer : c.moduleGraph.getIssuer(m);
+
+  if (issuer) {
+    return recursiveIssuer(issuer, c);
   }
 
-  // eslint-disable-next-line no-underscore-dangle
-  const chunks = webpackVersion === '4' ? m._chunks : m.getChunks();
+  const chunks =
+    // eslint-disable-next-line no-underscore-dangle
+    webpackVersion[0] === '4' ? m._chunks : c.chunkGraph.getModuleChunks(m);
 
   for (const chunk of chunks) {
     return chunk.name;
@@ -36,14 +40,16 @@ module.exports = {
         aStyles: {
           name: 'styles_a',
           test: (m, c, entry = 'a') =>
-            m.constructor.name === 'CssModule' && recursiveIssuer(m) === entry,
+            m.constructor.name === 'CssModule' &&
+            recursiveIssuer(m, c) === entry,
           chunks: 'all',
           enforce: true,
         },
         bStyles: {
           name: 'styles_b',
           test: (m, c, entry = 'b') =>
-            m.constructor.name === 'CssModule' && recursiveIssuer(m) === entry,
+            m.constructor.name === 'CssModule' &&
+            recursiveIssuer(m, c) === entry,
           chunks: 'all',
           enforce: true,
         },