Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Missing semicolon after "@import url(path/to/css) screen and (max-width:1024px) " #1049

Closed
Fi2zz opened this issue Sep 7, 2023 · 0 comments · Fixed by #1072
Closed

Comments

@Fi2zz
Copy link
Contributor

Fi2zz commented Sep 7, 2023

Actual Behavior

// missing  `;` at the end of line
@import url(http://some/path/to/css.css) screen and (max-width:1024)

Expected Behavior

// should have  `;` at the end of line
@import url(http://some/path/to/css.css) screen and (max-width:1024);

How Do We Reproduce?

this can be found in this line.
https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/src/index.js#L1367

 // HACK for IE
        // http://stackoverflow.com/a/14676665/1458162
        if (module.media) {
          // insert media into the @import
          // this is rar
          // TODO improve this and parse the CSS to support multiple medias
          content = content.replace(/;|\s*$/, module.media); //**!!!!!** module.media missing ';'
        }
@Fi2zz Fi2zz changed the title [bug] Missing semicolon on "@import url(path/to/css) screen and (max-width:1024px) " [bug] Missing semicolon after "@import url(path/to/css) screen and (max-width:1024px) " Sep 8, 2023
Yegorich555 pushed a commit to Yegorich555/webpack-must-have that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant