Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onerror request of event.target should be href rather than src #345

Closed
wants to merge 1 commit into from

Conversation

WilsonLiu95
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The url of link should be href rather than src. Although now has fullhref final return.

'var request = event && event.target && event.target.src || fullhref;',

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Feb 1, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wilsonsliu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Can you describe?

@alexander-akait
Copy link
Member

Also please accept CLA

@WilsonLiu95
Copy link
Author

WilsonLiu95 commented Feb 13, 2019

Why? Can you describe?

This should be get value of link element.

// error
var request = event && event.target && event.target.src || fullhref;,

// recom
var request = event && event.target && event.target.href || fullhref;,

@cap-Bernardito cap-Bernardito mentioned this pull request Oct 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants