chore: initial work on webpack 5 integration #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Don't worry we update plugin before stable release webpack@5, right now the plugin doesn't work? |
|
@evilebottnawi Thanks! Im not worried :) There are a couple of deprecation warnings and I would appreciate help and/or feedback to get a beta of this plugin without the warnings for integration in facebook/create-react-app#7929 Thanks 🙌 |
|
@andriijas just ignore deprecation messages right now, it is not break code or something important |
|
Compatibility is fixed, release will be soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Webpack 5 is coming, lets work together to make this plugin compatible!
Breaking Changes
Not sure, this PR should be considered DRAFT and not ready yet
Additional Info
Im a webpack amateur. But there is no better way to try to learn than practice, right?
Please provide feedback if this is on the right track and what more thinks to consider.
I would also like to know if there is a way to make the plugin compatible with both webpack 4 and 5.
Known issues