fix: crash when publicPath is function
#881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 91.28% 91.32% +0.03%
==========================================
Files 6 6
Lines 792 795 +3
Branches 214 216 +2
==========================================
+ Hits 723 726 +3
Misses 63 63
Partials 6 6
Continue to review full report at Codecov.
|
|
When will new version containing this fix be published? It seems that this PR has been merged over 20 days but no new version is published 😂 @alexander-akait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #873
Breaking Changes
No
Additional Info
There is limitation -
hashisxxxxx, because we don't know hash at this stage, we are building modules and hash calculation is impossible right now