feat: remove the ident property from loader options (#446)

webpack-contrib · Aug 17, 2020 · 53f678d · 53f678d
1 parent a043922
commit 53f678d
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 43 deletions.
diff --git a/README.md b/README.md
@@ -309,7 +309,6 @@ module.exports = {
         test: /\.css$/i,
         loader: 'postcss-loader',
         options: {
-          ident: 'postcss',
           plugins: (loader) => [
             require('postcss-import')({ root: loader.resourcePath }),
             require('postcss-preset-env')(),
@@ -322,8 +321,6 @@ module.exports = {
 };
 ```
 
-> ⚠️ webpack requires an identifier (`ident`) in `options` when `{Function}/require` is used (Complex Options). The `ident` can be freely named as long as it is unique. It's recommended to name it (`ident: 'postcss'`)
-
 **`webpack.config.js`**
 
 ```js
@@ -334,7 +331,6 @@ module.exports = {
         test: /\.css$/i,
         loader: 'postcss-loader',
         options: {
-          ident: 'postcss',
           plugins: {
             'postcss-import': {},
             'postcss-nested': {},
@@ -371,7 +367,6 @@ module.exports = {
         test: /\.css$/i,
         loader: 'postcss-loader',
         options: {
-          ident: 'postcss',
           plugins: {
             'postcss-import': {},
             'postcss-nested': {},
@@ -586,7 +581,7 @@ module.exports = {
 ### `SourceMap`
 
 Type: `Boolean|String`
-Default: `undefined`
+Default: `compiler.devtool`
 
 By default generation of source maps depends on the devtool option.
 All values enable source map generation except eval and false value.
@@ -667,7 +662,6 @@ module.exports = {
           {
             loader: 'postcss-loader',
             options: {
-              ident: 'postcss',
               plugins: [require('postcss-import')(), require('stylelint')()],
             },
           },
@@ -694,7 +688,6 @@ module.exports = {
           {
             loader: 'postcss-loader',
             options: {
-              ident: 'postcss',
               plugins: [require('autoprefixer')({ ...options })],
             },
           },

diff --git a/test/options/__snapshots__/config.test.js.snap b/test/options/__snapshots__/config.test.js.snap
@@ -54,15 +54,6 @@ exports[`Config Options should work Config - {Object}: errors 1`] = `Array []`;
 
 exports[`Config Options should work Config - {Object}: warnings 1`] = `Array []`;
 
-exports[`Config Options should work Config - Context - {Object} - with ident: css 1`] = `
-"a { color: rgba(255, 0, 0, 1.0) }
-"
-`;
-
-exports[`Config Options should work Config - Context - {Object} - with ident: errors 1`] = `Array []`;
-
-exports[`Config Options should work Config - Context - {Object} - with ident: warnings 1`] = `Array []`;
-
 exports[`Config Options should work Config - Context - {Object}: css 1`] = `
 "a { color: rgba(255, 0, 0, 1.0) }
 "

diff --git a/test/options/config.test.js b/test/options/config.test.js
@@ -131,23 +131,6 @@ describe('Config Options', () => {
     expect(getErrors(stats)).toMatchSnapshot('errors');
   });
 
-  it('should work Config - Context - {Object} - with ident', async () => {
-    const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
-      config: {
-        path: 'test/fixtures/config/postcss.config.js',
-        ctx: { plugin: true },
-      },
-    });
-    const stats = await compile(compiler);
-
-    const codeFromBundle = getCodeFromBundle('style.css', stats);
-
-    expect(codeFromBundle.css).toMatchSnapshot('css');
-    expect(getWarnings(stats)).toMatchSnapshot('warnings');
-    expect(getErrors(stats)).toMatchSnapshot('errors');
-  });
-
   it('should work Config – Context – Loader {Object}', async () => {
     const compiler = getCompiler('./css/index.js', {
       config: {

diff --git a/test/options/parser.test.js b/test/options/parser.test.js
@@ -60,7 +60,6 @@ describe('Options Parser', () => {
                   loader: path.resolve(__dirname, '../../src'),
                   // eslint-disable-next-line global-require
                   options: {
-                    ident: 'postcss',
                     // eslint-disable-next-line global-require,import/no-dynamic-require
                     parser: require('sugarss'),
                     config: false,
@@ -99,7 +98,6 @@ describe('Options Parser', () => {
                   loader: path.resolve(__dirname, '../../src'),
                   // eslint-disable-next-line global-require
                   options: {
-                    ident: 'postcss',
                     // eslint-disable-next-line global-require,import/no-dynamic-require
                     parser: require('sugarss').parse,
                     config: false,

diff --git a/test/options/plugins.test.js b/test/options/plugins.test.js
@@ -9,7 +9,6 @@ import {
 describe('Options Plugins', () => {
   it('should work Plugins - {Array}', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       plugins: [require('../fixtures/config/plugin')()],
     });
@@ -24,7 +23,6 @@ describe('Options Plugins', () => {
 
   it('should work Plugins - {Object}', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       plugins: require('../fixtures/config/plugin'),
     });
@@ -39,7 +37,6 @@ describe('Options Plugins', () => {
 
   it('should work Plugins - {Function} - {Array}', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       plugins: () => [require('../fixtures/config/plugin')()],
     });
@@ -54,7 +51,6 @@ describe('Options Plugins', () => {
 
   it('should work Plugins - {Function} - {Object}', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       plugins: () => require('../fixtures/config/plugin')(),
     });

diff --git a/test/options/stringifier.test.js b/test/options/stringifier.test.js
@@ -23,7 +23,6 @@ describe('Options Stringifier', () => {
 
   it('should work Stringifier - {Object}', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       stringifier: require('sugarss'),
       config: false,
@@ -58,7 +57,6 @@ describe('Options Stringifier', () => {
 
   it('should emit error Stringifier', async () => {
     const compiler = getCompiler('./css/index.js', {
-      ident: 'postcss',
       // eslint-disable-next-line global-require
       stringifier: 'unresolved',
       config: false,

diff --git a/test/options/syntax.test.js b/test/options/syntax.test.js
@@ -59,7 +59,6 @@ describe('Options Syntax', () => {
                 {
                   loader: path.resolve(__dirname, '../../src'),
                   options: {
-                    ident: 'postcss',
                     // eslint-disable-next-line global-require
                     syntax: require('sugarss'),
                     config: false,