Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed inline value for the sourceMap option #454

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

alexander-akait
Copy link
Member

BREAKING CHANGE: the inline value was removed for the sourceMap option, please use { map: { inline: true, annotation: false } } to achieve this

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

No need misleading options, also it is break source maps in many cases, but you still can achieve this

Breaking Changes

Yes

Additional Info

No

BREAKING CHANGE: the `inline` value was removed for the `sourceMap` option, please use `{ map: { inline: true, annotation: false } }` to achieve this
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #454 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   96.41%   96.38%   -0.03%     
==========================================
  Files           5        5              
  Lines         251      249       -2     
  Branches       76       74       -2     
==========================================
- Hits          242      240       -2     
  Misses          8        8              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d84f7...f4d3464. Read the comment docs.

@alexander-akait alexander-akait merged commit 677c2fe into master Sep 1, 2020
@alexander-akait alexander-akait deleted the refactor-remove-source-map-inline branch September 1, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant