Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update before release #659

Merged
merged 3 commits into from
Jun 10, 2023

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

regenerate lock file and validate latest version before release

Breaking Changes

No

Additional Info

No

@alexander-akait
Copy link
Member Author

@d-fischer there is a breaking change with .mjs implementation

Example:

import { cosmiconfig, defaultLoaders } from "cosmiconfig";

console.log(defaultLoaders[".js"]);

Before it was sync function https://github.com/cosmiconfig/cosmiconfig/blob/v8.0.0/src/loaders.ts#L7, now it is async, I am afraid you will get a lot of issue about it soon, I think not many have been updated yet, so everything is fine for now.

I can patch it here, but a lot of CLI tools use postcss-loader and can't easy update it.

@alexander-akait
Copy link
Member Author

Perhaps we should have introduced this improvement under a new major release, but it is too late to change it.

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28 🎉

Comparison is base (e754c3f) 88.41% compared to head (f880ff1) 88.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   88.41%   88.70%   +0.28%     
==========================================
  Files           3        3              
  Lines         354      354              
  Branches      115      115              
==========================================
+ Hits          313      314       +1     
+ Misses         38       37       -1     
  Partials        3        3              
Impacted Files Coverage Δ
src/utils.js 86.41% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 684d265 into master Jun 10, 2023
@alexander-akait alexander-akait deleted the chore-deps-update-before-release branch June 10, 2023 00:42
@d-fischer
Copy link

d-fischer commented Jun 10, 2023

Just wondering - as the containing function is already async, why didn't you just add an await?

I agree that multiple people including myself missed that this is breaking, and should have been part of a major release, but reverting now would by itself be another breaking change.

@alexander-akait
Copy link
Member Author

@d-fischer

Just wondering - as the containing function is already async, why didn't you just add an await?

Due to jest and Node.js, we have a custom implementation for loading to avoid memory leak, so I want to just use import-refresh with require here and do not try to import(...) if it was failed, it is faster and due new Function(...) Node.js remove it from cache after gc

I agree that multiple people including myself missed that this is breaking, and should have been part of a major release, but reverting now would by itself be another breaking change.

yeah, I agree, reverting this will be a problem more, maybe we should add notes in changelog about it, so it wasn't a surprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants