-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update before release #659
Conversation
@d-fischer there is a breaking change with Example: import { cosmiconfig, defaultLoaders } from "cosmiconfig";
console.log(defaultLoaders[".js"]); Before it was sync function https://github.com/cosmiconfig/cosmiconfig/blob/v8.0.0/src/loaders.ts#L7, now it is async, I am afraid you will get a lot of issue about it soon, I think not many have been updated yet, so everything is fine for now. I can patch it here, but a lot of CLI tools use postcss-loader and can't easy update it. |
Perhaps we should have introduced this improvement under a new major release, but it is too late to change it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 88.41% 88.70% +0.28%
==========================================
Files 3 3
Lines 354 354
Branches 115 115
==========================================
+ Hits 313 314 +1
+ Misses 38 37 -1
Partials 3 3
☔ View full report in Codecov by Sentry. |
Just wondering - as the containing function is already async, why didn't you just add an I agree that multiple people including myself missed that this is breaking, and should have been part of a major release, but reverting now would by itself be another breaking change. |
Due to jest and Node.js, we have a custom implementation for loading to avoid memory leak, so I want to just use
yeah, I agree, reverting this will be a problem more, maybe we should add notes in changelog about it, so it wasn't a surprise |
This PR contains a:
Motivation / Use-Case
regenerate lock file and validate latest version before release
Breaking Changes
No
Additional Info
No