Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with node-sass-import-once #275

Closed
webdesserts opened this issue Sep 1, 2016 · 2 comments
Closed

Error with node-sass-import-once #275

webdesserts opened this issue Sep 1, 2016 · 2 comments

Comments

@webdesserts
Copy link

webdesserts commented Sep 1, 2016

Hello and thanks for your work!
After the latest update(v4.01) I'm getting the following error while trying to use the node-sass-import-once importer.

Error building modules/Users/mcmullins/dev/apps/veracity/node_modules/node-sass-import-once/index.js:275
  if (!this.options.importOnce) {
           ^

TypeError: Cannot read property 'options' of undefined
    at importer (/Users/mcmullins/dev/apps/veracity/node_modules/node-sass-import-once/index.js:275:12)
    at Object.<anonymous> (/Users/mcmullins/dev/apps/veracity/node_modules/sass-loader/index.js:412:20)
    at options.importer.(anonymous function) (/Users/mcmullins/dev/apps/veracity/node_modules/node-sass/lib/index.js:30

It's seems like the importer is expected to be called with some sort of context, but that context is missing? Is this something that's expected with the latest changes?

Relevant Lines
https://github.com/at-import/node-sass-import-once/blob/master/index.js#L283
https://github.com/jtangelder/sass-loader/blob/master/index.js#L412

jhnns added a commit that referenced this issue Sep 7, 2016
This is a regression that was introduced with fd6be1f

#275 #277
This was referenced Sep 7, 2016
@webdesserts
Copy link
Author

I'm going to go ahead and close this, thnx for the fix.

@rohanbhangui
Copy link

still having an issue with this. Have version 6.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants