fix: generate correct sourceMaps when custom importer is used #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate correct sourceMaps when custom importer is used. sass/sass#3300 webpack-contrib#1217
alexander-akait
previously approved these changes
Aug 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
- Coverage 94.44% 94.18% -0.26%
==========================================
Files 3 3
Lines 360 413 +53
Branches 132 156 +24
==========================================
+ Hits 340 389 +49
- Misses 18 22 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Generate correct sourceMaps when custom importer is used. sass/sass#3300 webpack-contrib#1217
|
Changed Commit message for type lint. |
|
@DaiQiangReal Added test, let's wait CI |
alexander-akait
previously approved these changes
Aug 19, 2024
|
Ignore commit message I will fix it when will merge |
alexander-akait
merged commit f862f7a
into
webpack-contrib:master
12 of 14 checks passed
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Generate correct sourceMaps when custom importer is used.
sass/sass#3300
#1217
Breaking Changes
Additional Info