Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Webpack 2 peer dependency to 2.2 rc ver #323

Closed
wants to merge 1 commit into from

Conversation

harounb
Copy link

@harounb harounb commented Dec 16, 2016

Did this to resolve the unmet peer dependency error.
If you would like to retain support for 2.1 let me know and I'll amend.
I assumed you wouldn't as you're only supporting one version of webpack v1

Edit:
Thinking about this a little more could someone explain to me why the current package.json doesn't work fine?
the jump from 2.1 to 2.2 is a minor release so surely ^2.1 should cover that.
I'm quite confused even though it does appear to have worked.
If what I have done isn't suitable please let me know and I shall close.

Thanks

@kmontag
Copy link

kmontag commented Dec 17, 2016

@harounb I believe between pre-release versions, ^ treats minor version bumps as it would normally treat major ones.

@mattlewis92
Copy link
Member

I think that ^2 || ^2.2.0-rc.0 || ^2.1.0-beta || ^1.12.6 might be even better, as this is the convention the webpack loaders / plugins on the webpack org seem to be doing.

@graingert graingert mentioned this pull request Dec 21, 2016
@graingert
Copy link

@jtangelder can we get this merged?

@jtangelder
Copy link
Member

@mattlewis92 example of which loaders do this?

@graingert
Copy link

@jtangelder
Copy link
Member

Sorry @harounb, I'm having some git issues on my machine, wasn't able to enrich this PR. Still thanks!

@jtangelder jtangelder closed this Dec 21, 2016
@harounb
Copy link
Author

harounb commented Jan 2, 2017

@jtangelder No problem and great job :)
Apologies for vanishing after submitting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants