Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefer sass (dart-sass) by default #826

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Use sass (dart-sass by default)

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #826 into master will not change coverage by %.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          10       10           
  Lines         181      181           
  Branches       62       62           
=======================================
  Hits          175      175           
  Misses          6        6           
Impacted Files Coverage Δ
src/getDefaultSassImplementation.js 55.55% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74b5aa...ba46e8d. Read the comment docs.

@alexander-akait alexander-akait merged commit 3ad5291 into master Apr 11, 2020
@alexander-akait alexander-akait deleted the feat-prefer-sass-dart-sass-by-default branch April 11, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant