-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support node-sass v5.0.0 #899
Conversation
New projects with node-sass are returning an error due to latest being bumped to v5 `Error: Node Sass version 5.0.0 is incompatible with ^4.0.0.`
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 4 4
Lines 226 226
Branches 72 72
=======================================
Hits 217 217
Misses 8 8
Partials 1 1
Continue to review full report at Codecov.
|
Fixes #898 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
`node-sass` v5 introduced support for Node.js v15, which is not supported by v4. However, Next.js currently errors with ``` Error: Node Sass version 5.0.0 is incompatible with ^4.0.0. ``` when attempting to build with `node-sass` 5.0.0. This error comes from `sass-loader`. They have recently released version 10.0.5 which supports `node-sass` 5.0.0 (PR <webpack-contrib/sass-loader#899>, release <https://github.com/webpack-contrib/sass-loader/releases/tag/v10.0.5>).
New projects with node-sass are returning an error due to latest being bumped to v5
Error: Node Sass version 5.0.0 is incompatible with ^4.0.0.
This PR contains a:
Motivation / Use-Case
Every new (or updated) project using node-sass latest version will result in compilation errors during to mismatch semver.
Breaking Changes
Supports >4.0.0, open to changes.
Additional Info
None