Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat hmr for css modules #466

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Feat hmr for css modules #466

merged 3 commits into from
Apr 24, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 24, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

hmr for css modules

Breaking Changes

No

Additional Info

It is hard to write tests for hmr, so tested manually, feel free to open a new issue if you have a problems with this

fixes #422

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #466 into master will decrease coverage by 0.38%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   99.06%   98.68%   -0.39%     
==========================================
  Files           4        5       +1     
  Lines         215      228      +13     
  Branches       91       96       +5     
==========================================
+ Hits          213      225      +12     
- Misses          2        3       +1     
Impacted Files Coverage Δ
src/index.js 93.75% <60.00%> (-1.91%) ⬇️
src/runtime/isEqualLocals.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26bfaa5...70ff3ac. Read the comment docs.

@alexander-akait alexander-akait merged commit 6d14e0a into master Apr 24, 2020
@alexander-akait alexander-akait deleted the feat-hmr-for-css-modules branch April 24, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR does not work as of 1.0.0
1 participant