fix: cache for extracted comments (#314)

webpack-contrib · Sep 15, 2020 · 5340814 · 5340814
1 parent bbfa283
commit 5340814
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 10 deletions.
diff --git a/src/Webpack4Cache.js b/src/Webpack4Cache.js
@@ -55,6 +55,8 @@ export default class Webpack4Cache {
       input,
       inputSourceMap,
       extractedComments,
+      banner,
+      shebang,
     } = cachedResult;
 
     if (map) {
@@ -70,6 +72,14 @@ export default class Webpack4Cache {
       cachedResult.source = new RawSource(code);
     }
 
+    if (banner) {
+      cachedResult.source = new ConcatSource(
+        shebang ? `${shebang}\n` : '',
+        `/*! ${banner} */\n`,
+        cachedResult.source
+      );
+    }
+
     if (extractedComments) {
       cachedResult.extractedCommentsSource = new RawSource(extractedComments);
     }
@@ -105,6 +115,8 @@ export default class Webpack4Cache {
         map: cacheData.map,
         input: cacheData.input,
         inputSourceMap: cacheData.inputSourceMap,
+        banner: cacheData.banner,
+        shebang: cacheData.shebang,
       };
 
       if (cacheData.extractedCommentsSource) {

diff --git a/src/index.js b/src/index.js
@@ -323,6 +323,7 @@ class TerserPlugin {
 
           let output = await cache.get(cacheData, {
             RawSource,
+            ConcatSource,
             SourceMapSource,
           });
 
@@ -433,6 +434,8 @@ class TerserPlugin {
                     `/*! ${banner} */\n`,
                     output.source
                   );
+                  output.banner = banner;
+                  output.shebang = shebang;
                 }
               }